This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Conversation
- Jump was a separate project that I created to factor out some grpah related utilites around static analysis. I am now adding these utlities to Util so that Blinky does not depend on yet another project outside gh/spideruci/blinky. - I had to modify the compiler setting for Util from 1.7 -> 1.8, since I was using a few lambdas in Jump. Added a different task to track the work needed to upgrade Blinky to Java 8. - Testing: Build passing on the following commands: `mvn clean && mvn compile && mvn test`
Migrating from Jump to Blinky Util for all Graph related utilites that were earlier housed in Jump (see gh/vijaykrishna/jump). Testing: Build passing on the following commands: mvn clean -P statik mvn compile -P statik mvn test -P statik
kajdreef
approved these changes
Jun 4, 2018
Member
|
Looks good, I tested the changes the changes and have been able to compile and run all the tests without any problems. I will merge it now. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #44. Two stage change (copying notes from commit notes):
Change to Blinky Util
grpah related utilites around static analysis. I am now adding
these utlities to Util so that Blinky does not depend on yet
another project outside gh/spideruci/blinky.
since I was using a few lambdas in Jump. Added a different task
to track the work needed to upgrade Blinky to Java 8: see Upgrade all compiler settings from 1.7 -> 1.8 #45
mvn clean && mvn compile && mvn testChange to Blinky Statik
Migrating from Jump to Blinky Util for all Graph related utilites
that were earlier housed in Jump (see gh/vijaykrishna/jump).
Testing: Build passing on the following commands:
mvn clean -P statik
mvn compile -P statik
mvn test -P statik